MetaMask / MetaMask/core

Fix Invalid type assignment in SafeEventEmitterProvider

Open
#4,608 4 comments 0 reactions 1 assignee Claimed by @kanthesha View on GitHub
team-wallet-framework wf-eip1193
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `Record` type assigned to response of `convertEip1193RequestToJsonRpcRequest` does not belong here ([link](https://github.com/MetaMask/core/blob/a6177fb6a9727945ff7c0f831ce0f565bee3f65e/packages/eth-json-rpc-provider/src/safe-event-emitter-provider.ts#L33) to the code), no possible return value is represented by that type.

We need to fix/simplify the type assignment.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.