MetaMask / MetaMask/core

Re-enable ESLint rule `@typescript-eslint/no-unnecessary-type-assertion`

Open
#4,401 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-core-platform team-wallet-framework wf-lint-fixes
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

```ts
'@typescript-eslint/no-unnecessary-type-assertion': 'error',
```
Should be helpful for minimizing [redundant or silent-failure assertions](https://github.com/MetaMask/contributor-docs/blob/main/docs/typescript.md?rgh-link-date=2024-06-10T17%3A10%3A48Z#example-3675ab71-bcd6-4325-ac18-8ba4dd8ec03c).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository's ESLint configuration for the shown rule, then run the relevant lint command to identify violations across the monorepo. Done means the rule is enabled as an error and the resulting violations are resolved without weakening the rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.