MetaMask / MetaMask/core

improvement: SelectedNetworkController emit event for when a domains network is updated

Open
#4,151 0 comments 0 reactions 0 assignees View on GitHub
enhancement team-wallet-framework wf-general-dx
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Further, the QueuedRequestController should be listening for these events instead of `stateChange`.

related to this comment: https://github.com/MetaMask/core/pull/4139#discussion_r1561157147

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate SelectedNetworkController and QueuedRequestController in the monorepo and read their current event and stateChange handling. Confirm how a domain network update is represented, then make the queued request flow respond to the dedicated update event; done means the event is emitted and stateChange is no longer used for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.