MetaMask / MetaMask/core

Add unit tests for types

Open
#379 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

We should find some way to unit test some of our more complex types, to ensure they're guaranteeing exactly what we think they are. In particular, the types used by the Base Controller (and soon the controller messaging system) are fairly complex and deserve additional validation.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the complex types used by the Base Controller and reviewing the repository's existing unit-test setup. Determine which guarantees need validation, including types relevant to the controller messaging system, and consider the work done when those guarantees are covered by focused unit tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.