Refactor the `QRKeyring` to use the `Keyring` interface
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
# Description
The current QRKeyring from `@keystonehq/metamask-airgapped-keyring` has a custom interface that is not compatible with our current implementation. This work is aimed to align the `QRKeyring` to use our Keyring interface.
Consider starting a new repository to fully own the QRKeyring package.
**References**
- [Merge `eth-keyring-controller` and `@metamask/keyring-controller`](https://github.com/MetaMask/core/issues/2043)
- [Keyring interface](https://github.com/MetaMask/utils/blob/main/src/keyring.ts)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the QRKeyring package from @keystonehq/metamask-airgapped-keyring and the referenced Keyring interface in MetaMask/utils. Compare the custom interface with the current interface and determine the package ownership implications; done means QRKeyring uses the current Keyring interface, with any repository change resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100