MetaMask / MetaMask/core

[preferences-controller] Remove `identities` and `selectedAddress` state

Open
#3,700 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-assets team-wallet-framework wf-controller-tech-debt
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `identities` and `selectedAddress` state are redundant now that we have an `AccountsController`. They should be removed once we are ready to start using the `AccountsController` as the authoritative source of this information.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the preferences-controller and AccountsController entry points, then trace references to identities and selectedAddress and review their tests. Done means the redundant state is removed and AccountsController is the authoritative source wherever this information is needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.