MetaMask / MetaMask/core

Create EthereumAddress interface and class

Open
#25 1 comment 1 reaction 0 assignees View on GitHub
team-wallet-framework wf-still-a-thing
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

By having an interface EthereumAddress we can forget about all the type related issues (string vs hex, etc).

If we have an EthereumAddress obj also we could call toChecksumAddress inside of the constructor and have some utility function like toShortString (which could return `0x1234...1234`), etc.

cc: @danfinlay

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the repository's existing Ethereum address representations and the use of toChecksumAddress. Clarify the interface and class boundary, including constructor normalization and the proposed toShortString utility, before identifying affected callers and tests. Done means the design is agreed and the new abstraction consistently replaces the relevant string-versus-hex handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.