[json-rpc-middleware-stream] fix: clean up engine listener
Open
team-wallet-framework
wf-rpc-pipeline
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
Port the following PR that was ongoing in the `@metamask/json-rpc-middleware-stream` repo prior to its migration into the core monorepo.
- https://github.com/MetaMask/json-rpc-middleware-stream/pull/23 (author: @iantanwx)
There are some conflicts to resolve due to test rewrites that happen here: https://github.com/MetaMask/json-rpc-middleware-stream/pull/25.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing PR #23 in the former @metamask/json-rpc-middleware-stream repository and compare it with the test rewrites in PR #25. Port the ongoing change into the core monorepo, resolve the stated test conflicts, and verify that the resulting tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100