MetaMask / MetaMask/core

Re-enable `@typescript-eslint/no-misused-promises`

Open
#1,940 0 comments 0 reactions 0 assignees View on GitHub
team-core-platform team-wallet-framework wf-lint-fixes
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

There are 27 violations when I remove the override that turns this rule off and run `yarn eslint . --cache --ext js,ts --quiet`.

Fixing these violations may cause changes in behavior, so we should look at these manually.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the override that disables @typescript-eslint/no-misused-promises, then run `yarn eslint . --cache --ext js,ts --quiet` to reproduce the 27 violations. Review each violation manually for behavior changes and re-enable the rule once all violations are addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.