MetaMask / MetaMask/core

Re-enable `@typescript-eslint/no-floating-promises`

Open
#1,937 0 comments 0 reactions 0 assignees View on GitHub
team-core-platform team-wallet-framework wf-lint-fixes
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

There are 100 violations when I remove the override that turns this rule off and run `yarn eslint . --cache --ext js,ts --quiet`.

Some of these are intentional, but many may not be. Regardless, they cannot be autocorrected, so we will have to correct them by hand.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by removing the override for @typescript-eslint/no-floating-promises and run `yarn eslint . --cache --ext js,ts --quiet`. Review the 100 reported violations, determine which are intentional, correct the remaining ones by hand, and rerun the command until the rule can be re-enabled without unintended violations.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.