MetaMask / MetaMask/core

Re-enable `@typescript-eslint/naming-convention`

Open
#1,936 0 comments 0 reactions 0 assignees View on GitHub
team-core-platform team-wallet-framework wf-lint-fixes
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

There are 514 violations when I remove the override that turns this rule off and run `yarn eslint . --cache --ext js,ts --quiet`.

There are four types of violations:

- Enum members that should be `PascalCase`
- Type parameters that should be more than one character
- Property names that should be `camelCase`, `PascalCase` or `UPPER_CASE`
- Variable names that should be `camelCase`, `PascalCase` or `UPPER_CASE`

Other than variable names, these would cause backward-incompatible changes, so we may want to handle them by adding overrides at the violation site with a comment such as:

``` typescript
// This rule was added after this code was in place;
// we are keeping this name for backward compatibility
// eslint-disable-next-line @typescript-eslint/naming-convention
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by removing the override for @typescript-eslint/naming-convention and run `yarn eslint . --cache --ext js,ts --quiet` to inspect the 514 violations. Group findings by enum members, type parameters, properties, and variables; preserve incompatible public names with targeted eslint comments where needed. Done means the lint command passes with the rule enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.