MetaMask / MetaMask/core

Re-enable `@typescript-eslint/await-thenable`

Open
#1,935 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-core-platform team-wallet-framework wf-lint-fixes
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

There are 31 violations when I remove the override that turns this rule off and run `yarn eslint . --cache --ext js,ts --quiet`.

Unfortunately, these violations cannot be autocorrected, so we need to go through these manually and decide what to do.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the override that disables @typescript-eslint/await-thenable, then run `yarn eslint . --cache --ext js,ts --quiet` to review the 31 reported violations. Handle each violation manually according to the appropriate decision, remove the override, and confirm the lint command completes without these violations.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.