Re-enable `@typescript-eslint/promise-function-async`
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
There are 159 violations when I remove the override that turns this rule off and run `yarn eslint . --cache --ext js,ts --quiet`.
Running `yarn eslint . --cache --ext js,ts --quiet --fix` to autocorrect these violations is not enough, because tests for the following packages fail due to changing behavior:
- `@metamask/approval-controller`
- `@metamask/permission-controller`
- `@metamask/assets-controllers`
- `@metamask/transaction-controller`
- `@metamask/keyring-controller`
We need to look at these test failures and understand why they're happening and correct them manually.
Contributor guide
No contributing guide indexed for this repository
Research direction
Remove the override for @typescript-eslint/promise-function-async and run `yarn eslint . --cache --ext js,ts --quiet --fix` to identify the 159 violations. Then investigate the failing tests in @metamask/approval-controller, @metamask/permission-controller, @metamask/assets-controllers, @metamask/transaction-controller, and @metamask/keyring-controller; done means the rule is enabled, lint passes, and these package tests pass without behavior changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- testing-qa, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100