MetaMask / MetaMask/core

Remove unnecessary ESLint overrides

Open
#1,923 0 comments 0 reactions 0 assignees View on GitHub
team-core-platform team-wallet-framework wf-lint-fixes
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

There are a fair amount of overrides in our ESLint configuration file:

- We have some rules we've disabled because they were inconvenient to use at the time. We should correct the usages so that we can remove these overrides.
- We have some we've disabled because they were automatically enabled via an upgrade to our ESLint config packages, and we didn't have time to adjust the code to match. We should make the proper adjustments so that we can remove these overrides.
- We have some rules whose behavior we've modified because it made more sense. We should consider copying these changes into the ESLint config monorepo.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the ESLint configuration file and cataloging the existing overrides, then inspect the code affected by each rule. Done means unnecessary overrides are removed after the corresponding usages are corrected, with behavior changes that belong in the ESLint config monorepo identified for consideration.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.