MetaMask / MetaMask/core

TokenDetectionController: Write comprehensive unit tests

Open
#1,615 4 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

We should review the tests for TokenDetectionController and ensure that the functionality and edge cases are well-covered by tests and that there are no duplicative or unnecessary tests. A new contributor should be able to use the tests as a guideline for what the controller does.

~There were API changes made recently to TokenDetectionController, so we should focus on backfilling tests for those especially.~ This is no longer the case, but see comments below for updates.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating TokenDetectionController and its existing tests in the monorepo, then read the controller and run its current unit-test suite. Use the existing tests to identify uncovered functionality and edge cases, remove duplicative or unnecessary cases, and consider the work done when the tests clearly describe the controller's behavior and pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.