MetaMask / MetaMask/core

TokensController: Refactor

Open
#1,613 0 comments 0 reactions 0 assignees View on GitHub
team-assets team-wallet-framework wf-controller-tech-debt
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `addToken`, `addTokens`, `ignoreTokens`, `addDetectedTokens`, and `_getAllTokensState` methods seem to be complex. We should split these methods up, extracting logic to separate files, so that they are easier to understand and test.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate TokensController and its existing tests, then read addToken, addTokens, ignoreTokens, addDetectedTokens, and _getAllTokensState to map their responsibilities and dependencies. Done means the logic is split into understandable, testable units while preserving the existing behavior and keeping the tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.