MetaMask / MetaMask/core

PhishingController: Refactor

Open
#1,608 0 comments 0 reactions 0 assignees View on GitHub
team-assets team-wallet-framework wf-controller-tech-debt
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `#updateStalelist` and `#updateHotlist` method seem to have multiple responsibilities. We should investigate whether there is a way to extract the complexity so it is easier to test this class.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the PhishingController implementation and inspect #updateStalelist and #updateHotlist, along with any existing tests for the class. Trace the responsibilities of both methods and determine how they could be separated. Done means the controller is easier to test without changing its behavior, with focused tests covering the extracted responsibilities.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.