MetaMask / MetaMask/core

NftController: Refactor

Open
#1,606 0 comments 0 reactions 0 assignees View on GitHub
team-assets team-wallet-framework wf-controller-tech-debt
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

NftController makes several API calls to request information about NFTs. Most of the code is contain in private methods. Additionally, there is a lot of code around normalizing returned API data which increases the complexity. This code should be extracted to separate files and then refactored appropriately. This should make that code easier to test as well.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating NftController and its private methods that make NFT API calls and normalize returned data. Map those responsibilities before deciding how to extract them into separate files; done means the behavior is preserved and the extracted code is easier to test.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.