MetaMask / MetaMask/core

NftDetectionController: Write comprehensive unit tests

Open
#1,601 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The test coverage for NftDetectionController is below 100%. We should check each part of the API to ensure that it is completely tested so that we can raise coverage to 100%. We should also remove any `istanbul ignore` directives that may be present.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate NftDetectionController and its existing test coverage, then review each part of its API for untested paths. Add unit tests until coverage reaches 100%, remove any istanbul ignore directives that are no longer needed, and verify the coverage result.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.