MetaMask / MetaMask/core

NftController: Write comprehensive unit tests

Open
#1,597 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The test coverage for NftController is below 100%. We should check each part of the API to ensure that it is completely tested so that we can raise coverage to 100%. We should also remove any `istanbul ignore` directives that may be present.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate NftController and inspect its existing unit tests and any istanbul ignore directives. Run the current test and coverage commands, then cover each part of the API and remove applicable directives; done means NftController reaches 100% coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.