Improve phishing controller state names
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
The phishing controller state names are confusing at the moment, and they continue to use outdated terminology.
The phishing configuration lists still have some references to `whitelist` and `blacklist`, which are no longer used on the new configuration. We should update the default fallback configuration (or remove the fallback completely) so that these names are no longer referenced.
The local-only allowlist state is called `whitelist` as well, which makes it easily confused for the phishing configuration `allowlist` entries. We should rename it to something like `localAllowlist`, `safelist`, `safeExceptions`, etc. to make it more clear how it's different frrm the configuration.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the phishing controller and its phishing configuration lists, then trace references to the default fallback configuration and the local-only `whitelist` state. Review how the configuration `allowlist` entries differ from the local-only state, choose a consistent replacement name, and update all references. Verify the controller's existing tests or checks for the renamed states and removed terminology.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100