Investigate whether "cancel" transactions should be pushed to state in Transactions Controller as we do with "speed up" transactions
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
Is there some reason we don't add "cancel" transactions into the transactions array like we do with speedup transactions?
cancel: https://github.com/MetaMask/core/blob/a3b454eadbc9e974a6ee4a2729baf54171d422ed/packages/transaction-controller/src/TransactionController.ts#L824
speedup: https://github.com/MetaMask/core/blob/a3b454eadbc9e974a6ee4a2729baf54171d422ed/packages/transaction-controller/src/TransactionController.ts#L946
Contributor guide
No contributing guide indexed for this repository
Research direction
Compare the cancel transaction handling at TransactionController.ts#L824 with the speedup handling at TransactionController.ts#L946. Trace how each transaction reaches controller state and determine whether cancel transactions should be included in the transactions array. Done means the behavior is decided and, if a change is warranted, the relevant controller behavior is updated and verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100