[utils] Widen `isSafeDynamicKey` parameter type from `string` to `PropertyKey`
Open
Beginner friendly
Nobody has claimed this yet.
team-wallet-framework
wf-other
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
`isSafeDynamicKey` should be able to handle all `PropertyKey` types.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating isSafeDynamicKey and its existing tests in the MetaMask core monorepo. Update the parameter type from string to PropertyKey and verify the relevant tests and TypeScript checks pass for string, number, and symbol keys.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100