MetaMask / MetaMask/core

[utils] `JsonRpcRequestStruct` incompatible with superstruct `pick` and `omit`

Open
#10,201 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Following https://github.com/MetaMask/utils/commit/0d68084b8d8f64a59606b6559b901be4db7c0560 the `JsonRpcRequestStruct` is now incompatible with superstruct functions such as `pick` and `omit`. Trying to use them will result in a type error, see https://github.com/MetaMask/snaps/actions/runs/6823234052/job/18556824093 for an example.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing commit 0d68084b8d8f64a59606b6559b901be4db7c0560 and the failing MetaMask Snaps workflow linked in the issue. Trace how JsonRpcRequestStruct is typed and reproduce the error with superstruct pick and omit; done means both functions accept the struct without a TypeScript type error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.