MetaMask / MetaMask/browser-passworder

Regression in `decrypt` function return type

Open
#41 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
126
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Before #29, the `decrypt` function would return a `Promise` with a generic `R`. It was changed to return `Promise` instead, which breaks the implementation in `snaps-monorepo`, because `unknown` is not assignable to the `Json` type, while the generic `R` was.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the `decrypt` function and review the return-type change introduced by #29. Restore the generic `R` return contract described in the issue, then verify that the resulting type is assignable to the `Json` type used by snaps-monorepo.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.