MetaMask / MetaMask/action-publish-release
Action wrongly assumes tag does not exist when request fails for any reason
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
This action calculates the packages to release by querying for each tag one-by-one. If it fails to get any tag, it assumes the tag does not exist.
It's on this line: https://github.com/MetaMask/action-publish-release/blob/f01f1be110d60fb07d86c880ce3d6bdb353524d3/scripts/get-release-packages.sh#L56
This is a poor assumption. The request might fail due to a server error or rate limiting, even for a tag that does exist. This bad assumption recently caused a `core` release to fail.
The comment above this line even contradicts this behavior (it implies that it only fails on HTTP 404 responses).
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at scripts/get-release-packages.sh line 56 and read the comment immediately above it. Trace how failed tag requests are handled, then make the behavior distinguish a missing tag from other request failures; done means server errors and rate limits are no longer treated as absent tags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, shell
- Domain
- ci-cd, release
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100