MetaCell / MetaCell/geppetto-meta

Connectivity fix data being cropped

Open
#73 0 comments 0 reactions 0 assignees View on GitHub
bug geppetto-showcase
Dominant language
JavaScript
Stars
6
Forks
4
PR merge metrics
No merged PRs in 30d

Description

SVG data is being cropped.

[This](https://github.com/MetaCell/geppetto-meta/blob/development/geppetto.js/geppetto-ui/src/connectivity-viewer/ConnectivityComponent.js#L85
) looks like the relevant part of the code. If I remember correctly, the intent of that code is to try to fit the SVG into the container. But definitely not at the cost of cropping data.

How it looks:
![image](https://user-images.githubusercontent.com/19196034/117998881-372c6c80-b33c-11eb-9d1c-d2ef79cedf72.png)

How it should look:
![image](https://user-images.githubusercontent.com/19196034/118000895-21b84200-b33e-11eb-8bd2-960a84444963.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect geppetto.js/geppetto-ui/src/connectivity-viewer/ConnectivityComponent.js around line 85, where the SVG is fitted into its container. Reproduce the cropped and expected views using the attached examples, then verify that fitting the SVG preserves all connectivity data without cropping.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.