MetaCell / MetaCell/geppetto-meta

Allow preventing add_widget from changing the focus to the recently created widget

Open
#186 0 comments 0 reactions 0 assignees View on GitHub
breaking change enhancement geppetto-client
Dominant language
JavaScript
Stars
6
Forks
4
PR merge metrics
No merged PRs in 30d

Description

I believe [here](https://github.com/MetaCell/geppetto-meta/blob/development/geppetto.js/geppetto-client/js/common/layout/LayoutManager.tsx#L96)
The select attribute is defaulting to True.
![image](https://user-images.githubusercontent.com/19196034/138290270-b03cdd29-2e40-4f5e-b08a-97848d90f4e7.png)
I would want it to be False if the widget I pass has the status Hidden

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in geppetto.js/geppetto-client/js/common/layout/LayoutManager.tsx around line 96, where the select attribute defaults to true. Trace how add_widget handles widgets with Hidden status and verify the desired focus behavior. Done means a newly created hidden widget does not change focus, while the existing behavior remains for other widgets.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.