MetOffice / MetOffice/ukca

Further ASAD refactoring

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
11
Forks
38
Avg merge
17h 57m
Merged PRs (30d)
1

Description

Transfer of [ukca:#325](https://code.metoffice.gov.uk/trac/ukca/ticket/325) on MOSRS.

Following the completion of [ukca:#302](https://code.metoffice.gov.uk/trac/ukca/ticket/302), I spotted a few more things in ASAD that could do with refactoring. These include:

* Drop unused arrays and arguments from previous refactoring work.
* Use the more accurate array name `permuted_nonzero_map` rather than `nonzero_map_unordered`.
* Details on LU factorisation.
* Clarity of comments.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the ASAD code and the completed ukca:#302 refactoring referenced in the issue. Locate the unused arrays and arguments, the nonzero_map_unordered references, and the LU factorisation comments; done means removing obsolete items, applying the requested name, and improving the stated documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.