MetOffice / MetOffice/socrates
src/aux/qsat_wat.F90 contains OpenMP directives, but is not compiled with OpenMP
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 15
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
And trying to build everything with OpenMP exposes this error:
```
gfortran -fopenmp -O -c qsat_wat.f90
qsat_wat.f90:535:61:
535 | & ( MAX(P(I),QS(I)) - ONE_MINUS_EPSILON*QS(I) )
| ^
Error: 'repsilon' not specified in enclosing 'parallel'
qsat_wat.f90:499:48:
499 | !$OMP& PRIVATE(fsubw, tt, atable, itable, i)
| ^
note: enclosing 'parallel'
qsat_wat.f90:535:61:
535 | & ( MAX(P(I),QS(I)) - ONE_MINUS_EPSILON*QS(I) )
| ^
Error: 'one_minus_epsilon' not specified in enclosing 'parallel'
qsat_wat.f90:499:48:
499 | !$OMP& PRIVATE(fsubw, tt, atable, itable, i)
| ^
note: enclosing 'parallel'
make: *** [Mk_pattern:10: qsat_wat.o] Fehler 1
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/aux/qsat_wat.F90, especially the OpenMP directive around line 499, and inspect the build rule that compiles qsat_wat.f90. Reproduce the reported gfortran -fopenmp failure, then verify that the file builds successfully with OpenMP enabled and that the normal build remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- build-system, hpc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100