MetOffice / MetOffice/shumlib

Science error in horizontal interpolation at northern boundaries

Open
#31 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
4
Forks
10
PR merge metrics
No merged PRs in 30d

Description

The horizontal interpolation routines do not behave if points lie outside the northern bound of the original data. This was reported in a [MOSRS ticket](https://code.metoffice.gov.uk/trac/utils/ticket/188) years ago, but seems the fix never made it in to the trunk.

The rose-stem tests test running an n512 dump at n48 resolution, here shows going from an n48 dump to n512 resolution which demonstrates the problem:

Image

Image

We added the fix mentioned in the above Trac ticket in our fork (see [this commit](https://github.com/ACCESS-NRI/shumlib/commit/6adf418acdd62322f40e6ab31a9de36c59b24bfb)) and achieved desired results:

Image

Thanks @MartinDix and @paocorrales for doing the work identifying this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the horizontal interpolation routines and the rose-stem tests that exercise an n48 dump at n512 resolution. Compare the existing implementation with the linked ACCESS-NRI commit, then run the interpolation test case to verify that points beyond the northern boundary produce the expected results.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.