MetOffice / MetOffice/lfric_core

A more nuanced approach to constants

Open
#402 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
26
Forks
73
Avg merge
1d 8h
Merged PRs (30d)
4

Description

Currently there is `constants_mod` in infrastructure which holds constants used everywhere.

This is almost certainly conceptually wrong. Each model and the infrastructure should be responsible for managing their own constants. When it comes to matching type kinds this is handled by the compiler.

It is also likely to play badly with our desire to support multi-precision models.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating infrastructure/constants_mod and inventorying which constants are used by the models and infrastructure. Determine how constants related to type kinds are currently handled by the compiler, then define ownership for each remaining constant; done means the shared module no longer improperly owns model-specific constants and multi-precision concerns are addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
infrastructure
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.