MetOffice / MetOffice/lfric_core
Refactor io_value_type
@allynt is already working on this.
Since May 29, 2026.
- Dominant language
- Fortran
- Stars
- 26
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 4
Description
### Are there any linked Issues or Pull Requests?
https://github.com/MetOffice/lfric_apps/issues/557
### Brief description
There is no need for a separate `data` or `name` attribute on `io_value_type` b/c it inherits from `key_value_type` which *already* has a `value` and `key` attribute. This PR will remove those attributes and all the code pertaining to it, turning `io_value_type` into a specialisation of `key_value_type` whose only difference is that it contains procedure pointers for doing IO.
### Further details of the issue.
A previous issue (#183) to refactor `io_value_type` so that its attributes were private has been closed. The attributes of `key_value_type` are *purposefully* public to make the code simpler.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.