MetOffice / MetOffice/lfric_core

Use of gungho metadata in science component

Open
#305 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Fortran
Stars
26
Forks
73
Avg merge
1d 8h
Merged PRs (30d)
4

Description

### Version

main

### Are there any linked Issues or Pull Requests?

_No response_

### What happened?

The `compute_latlon` routine in `sci_geometric_constants_mod` module of the science component use the `f_lon` option from the `idealised` configuration namelist. This is not present within lfric_core and therefore this routine cannot be used within lfric_core.

Interestingly, the `f_lat` option is in the `base_mesh` configuration namelist, so can be used within lfric_core (possibly suggesting the correct solution as well).

Paging @tommbendall, any thoughts?

### Relevant log output

```shell

```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the compute_latlon routine in the sci_geometric_constants_mod module and compare how the science component reads f_lon from the idealised namelist with how f_lat is provided by base_mesh. Trace the configuration metadata available in lfric_core; done means compute_latlon can be used there without relying on unavailable idealised metadata.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.