MetOffice / MetOffice/lfric_core
Assess and possibly remove r_val and dp_val from constants_mod
- Dominant language
- Fortran
- Stars
- 26
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 4
Description
### Contact Details
@andrewcoughtrie
### Are there any linked Issues or Pull Requests?
ticket:4673
### Brief description
It appears that r_val and dp_val are poorly defined kinds that are never used in lfric (and shouldn't be used) so they should be removed. There may also be scope to tidy up `constants_mod.F90` in general.
### Further details of the issue.
_No response_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with constants_mod.F90 and ticket 4673, then search the repository for references to r_val and dp_val. Done means confirming whether they are unused and removing them if appropriate; any broader cleanup should be limited to what the module and ticket justify.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100