MetOffice / MetOffice/lfric_apps

Forking psyclone_tools in LFRic_Apps

Open
#672 0 comments 0 reactions 2 assignees Claimed by @MetBenjaminWent View on GitHub
enhancement
Dominant language
Fortran
Stars
31
Forks
118
Avg merge
2d 4h
Merged PRs (30d)
8

Description

### Are there any linked Issues or Pull Requests?

#663 - Umbrella Issue

### Brief description

As described in parent issue #663, we are looking to duplicate psyclone_tools from LFRic_Core into LFRic_Apps.

Linked to PR [726](https://github.com/MetOffice/lfric_apps/pull/726)

### Further details of the issue.

• Any scripts within LFRic_Apps, which use psyclone tools will be switched to using the LFRic_Apps version, therefore reducing dependencies across repositories.
• LFRic_Core’s psyclone_tools will be kept simple, with the tiling component of colouring moved to LFRic_Apps. Going forward the LFRic_apps version can be developed as a separate python library.
• User’s relying on psyclone_tools.py within lfric_core, who do not make use of LFRic_Apps, will be unaffected.

The specific location of psyclone_tools within LFRic_Apps is to be determined. An initial suggestion is lfric_apps/interfaces/build/.

Note: The dependency of LFRic_Apps on LFRic_Core is currently and should remain only one way. In no part of the duplication do we want Core to become dependent on material within Apps.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.