MetOffice / MetOffice/lfric_apps

RESOLVE_IMPORTS errors with PSyclone Transmute

Open
#613 0 comments 0 reactions 2 assignees Claimed by @EdHone View on GitHub
enhancement
Dominant language
Fortran
Stars
31
Forks
118
Avg merge
2d 4h
Merged PRs (30d)
8

Description

### Are there any linked Issues or Pull Requests?

_No response_

### Brief description

Whilst action-ing #424, we found that sometimes PSyclone could not tell if an subroutine call was a subroutine call or a shared local array.

It seems theres a way to reference the modules to allow PSyclone to determine these:
_In order to improve the PSyclone capabilities to convert implicit loops,
the details of externally declared symbols can be resolved by using the
`resolve_imports` method of the symbol table:

.. code-block:: python

import_symbol = symbol_table.lookup(module_name)
symbol_table.resolve_imports(container_symbols=[import_symbol])

.. footbibliography::_

_It needs to be combined with a "-I " that finds the dependent file_

However, this requires updates to the build system which both pre-process, and link the other files for the PSyclone step. This are WIP in the make build system, and likely will occur with the ToyBuild.

Raising this issue so unblock work in #607

### Further details of the issue.

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.