MetOffice / MetOffice/lfric_apps

Use `modeldb%config` object for importing config mod members in adjoint tests where possible

Open
#535 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Fortran
Stars
31
Forks
118
Avg merge
2d 4h
Merged PRs (30d)
8

Description

### Are there any linked Issues or Pull Requests?

_No response_

### Brief description

The `adjoint_tests` app uses the old-school way of global imports of config namelist variables. Now that https://github.com/MetOffice/lfric_core/pull/175 has been merged, we can utilise where possible the `modeldb%config` object to get the values of these variables.

### Further details of the issue.

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by searching the adjoint_tests app for global imports of configuration namelist variables and compare them with the available modeldb%config object introduced by lfric_core PR 175. Update the applicable imports to use modeldb%config, leaving unsupported cases unchanged, and run the adjoint tests to confirm their behavior is preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.