MetOffice / MetOffice/lfric_apps
Remove hardwired switch from boundary_layer routine excf_nl
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 31
- Forks
- 118
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
### Are there any linked Issues or Pull Requests?
_No response_
### Brief description
The switch `l_use_var_fixes` is hardwired to true in LFRic_apps, because all configurations use it that way, so here I just remove the switch to leave the code as it is ultimately used. Sadly, the compiler responds to this and breaks kgo but it still makes sense to clean up the code, I think
### Further details of the issue.
_No response_
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the boundary_layer routine excf_nl and trace how l_use_var_fixes is handled in LFRic_apps. Check the compiler failure reported for kgo before and after removing the hardwired switch; done means the cleanup preserves the intended behavior and kgo still builds successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100