MetOffice / MetOffice/lfric_apps
glomap_aerosol_kernel should use gh_scalar_array when available
- Dominant language
- Fortran
- Stars
- 31
- Forks
- 118
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
### Are there any linked Issues or Pull Requests?
#193
### Brief description
Once a new PSyclone release is adopted, the arrays used in glomap_aerosol_kernel_mod.F90 from modules can be passed as arguments into the kernel, so better meeting style guidelines for writing kernels.
Note that #193 intends to introduce rhcrit as a further array to be passed into this kernel.
### Further details of the issue.
_No response_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading glomap_aerosol_kernel_mod.F90 and the linked issue #193, then check the relevant PSyclone release changes. Confirm which module arrays can be passed into the kernel and where gh_scalar_array is available. Done means the kernel follows the stated argument-passing style without overlooking rhcrit from #193.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100