Fab does not abort in case of analyse errors
- Dominant language
- Python
- Stars
- 9
- Forks
- 9
- Avg merge
- 12d 12h
- Merged PRs (30d)
- 2
Description
I am not sure if this is done intentional, but Fab does not abort when an analysis error happens (see #576). This wastes potentially time (i.e. Fab might try to compile, even though one file was not analysed, and then a dependency is missing, and compilation error happens due to unknown symbols/missing .mod files).
A quick look indicates that the same would happen with the PSyclone step if I am not mistaken.
It should be reasonable easy to fix by adding a call to `check_error`, as e.g. is done in preprocessing.
Contributor guide
Research direction
Start by tracing the analysis step and comparing its error handling with preprocessing, where check_error is already used. Inspect the corresponding PSyclone step as well. Done means Fab aborts after analysis errors instead of continuing toward compilation, and the existing test suite confirms both paths behave correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100