MetOffice / MetOffice/fab

Fab reports contained subroutines as external symbols

Open
#557 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
9
Forks
9
Avg merge
12d 12h
Merged PRs (30d)
2

Description

While working on Socrates, I've found that code like:
```
program a
...
contains
subroutine b
end subroutine b
end program a
```
reports subroutine `b` as an external symbol (and then finds duplicated symbols, since many subroutine re-implement the same local subroutine :cry:

Contributor guide

Open the contributing guide

Research direction

Reproduce the report with the Fortran program shown in the issue, then trace Fab's symbol-discovery entry point to see why the contained subroutine is classified as external. Done means contained subroutines are excluded from external-symbol reports and duplicate-symbol findings no longer occur for this pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.