MetOffice / MetOffice/fab

Check PSyclone checksums

Open
#554 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
9
Forks
9
Avg merge
12d 12h
Merged PRs (30d)
2

Description

According to comments in the code, the PSyclone step hashes only the metadata of a PSyclone kernel, not the whole file.

That means that if a transformation script uses (module) inlining, and the implementation of a kernel changes, this will get undetected. While the new kernel will be compiled, PSyclone will not run again, and therefore the PSy-layer will keep on using the old implementation.

Contributor guide

Open the contributing guide

Research direction

Start by locating the PSyclone build step and the code comments describing its checksum inputs. Reproduce the module-inlining case and trace when the checksum is compared; the work is done when a changed kernel implementation invalidates the checksum and causes PSyclone to run again.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.