MetOffice / MetOffice/fab

Hand edited PSy files overwritten by PSyclone step

Open
#511 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
9
Forks
9
Avg merge
12d 12h
Merged PRs (30d)
2

Description

PSyclone step takes in algorithm `.x90` and transformation script `.py`. These are hashed and that has is applied to the generated PSy layer `.f90`. On future incremental builds in which the prerequisite files have not changed they should produce the same hash and therefore not trigger a rebuild, overwriting the PSy file. However hand edits to the PSy file (which do not change its filename) are being overwritten.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the PSyclone build step that consumes the algorithm .x90 file and transformation .py script and generates the .f90 PSy layer. Check how prerequisite hashes are compared with the generated file, then verify that an unchanged incremental build preserves hand edits while still rebuilding when an input changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.