MetOffice / MetOffice/dagrunner

Raise a TypeError in the Plugin abstract base class when no args provided

Open
#112 0 comments 1 reaction 1 assignee Claimed by @cpelley View on GitHub
Dominant language
Python
Stars
5
Forks
6
PR merge metrics
No merged PRs in 30d

Description

I think that, in the specific case where an application is invoked with no input arguments, there is a reasonable expectation that the abstract class should raise an exception rather than continue execution, even if derived classes would ultimately raise one themselves. A user explicitly providing no inputs is likely an error, and failing fast would provide clearer feedback. It would also guard against cases where input validation has not been implemented correctly in downstream classes.

Tangentially raised in PR #111

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.