MetOffice / MetOffice/Vernier

Potential swap to long int chrono durations

Open
#61 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
6
Forks
11
Avg merge
18h 7m
Merged PRs (30d)
1

Description

As @mo-mglover suggested, using `long int`'s for the chrono durations may help avoid floating point accumulation related problems. I say "potential swap" because I don't think it's currently clear what the pros and cons of making this change will be, but those can be discussed here. An associated branch will also be made where any relevant testing be done (e.g does it negatively or positively effect the runtime and reported walltimes?).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the chrono duration types and the code that reports runtime and walltime. Use the associated branch, if available, to compare long-integer and floating-point behavior, including runtime effects and accumulation accuracy. Done requires a justified decision based on those tests, not merely a representation change.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc, performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.