Incorrect halo depths in some adjoint kernels
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
For some adjoint kernels the halo depth is not being set correctly. This has led to PSyKAl-lite code -
* `invoke_atl_poly_adv_update_kernel_type`
* 'invoke_atl_w3h_adv_upd_kernel_type'
in `science/adjoint/source/psy/transport/mol/invoke_atl_poly_adv_update_mod.f90` and `science/adjoint/source/psy/transport/mol/invoke_atl_w3h_adv_upd_mod.f90` respectively.
This is documented in [PSyclone issue #2886](https://github.com/stfc/PSyclone/issues/2886)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with science/adjoint/source/psy/transport/mol/invoke_atl_poly_adv_update_mod.f90 and invoke_atl_w3h_adv_upd_mod.f90, then read PSyclone issue #2886 for the documented halo-depth problem. Compare the generated PSyKAl-lite code for both kernels and confirm that each uses the intended halo depth.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100