MetOffice / MetOffice/PSyTran

Read only arrays of scalars in PSyclone

Open
#94 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

LFRic apps PSyclone issue PSyKAl-lite
Dominant language
Python
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

There are a handful of PSyKAl-lite subroutines which exist because there isn't support in PSyclone for passing a read-only array of scalars. These subroutines are -

  • invoke_spectral_2_cs_kernel_type
  • invoke_heaviside_kernel_type
  • invoke_temp_on_pres_kernel_type
  • invoke_pres_interp_kernel_type
  • invoke_geo_on_pres_kernel_type

and are all found in science/um_physics_interface/source/psy/psykal_lite_phys_mod. To reduce clutter in the issue I will just list the various scripts that these are called from -

  • science/um_physics_interface/source/algorithm/stph_fp_main_alg_mod.x90
  • science/um_physics_interface/source/algorithm/pres_lev_diags_alg_mod.x90
  • science/um_physics_interface/source/algorithm/rh_diag_alg_mod.x90

There is also a PSyKAl-lite subroutine called invoke_atl_poly1d_vert_w3_recon_kernel_type in science/adjoint/source/psy/transport/mol/invoke_atl_poly1d_vert_w3_recon_mod.F90.

The corresponding PSyclone issue for this is PSyclone #1312.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the listed PSyKAl-lite subroutines in science/um_physics_interface/source/psy/psykal_lite_phys_mod and invoke_atl_poly1d_vert_w3_recon_kernel_type in science/adjoint/source/psy/transport/mol/invoke_atl_poly1d_vert_w3_recon_mod.F90. Review PSyclone issue #1312 and the listed algorithm callers; done means the read-only scalar arrays no longer require these workaround subroutines while the affected callers remain valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.