MetOffice / MetOffice/PSyTran

PSyclone builtins to run global reductions on fields

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

LFRic core PSyclone issue PSyKAl-lite
Dominant language
Python
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Currently, PSyclone doesn't have builtins which allow global reductions on fields. This functionality is requried and documented by [PSyclone issue #489](https://github.com/stfc/PSyclone/issues/489). This behaviour is intended to be implemented as a global reduction object in [PSyclone issue #2381](https://github.com/stfc/PSyclone/issues/2381).

Currently there are 3 PSyKAl-lite routines in LFRic core in `components/science/source/psy/sci_psykal_builtin_light_mod` which could be removed by the addition of this functionality. These are -

- `invoke_real32_field_min_max`
- `invoke_real64_field_min_max`
- `invoke_int32_field_min_max`

which are all called by `components/science/source/algorithm/sci_field_minmax_alg_mod.f90` in LFRic core.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading PSyclone issues #489 and #2381, then inspect the three PSyKAl-lite routines in components/science/source/psy/sci_psykal_builtin_light_mod and their use in components/science/source/algorithm/sci_field_minmax_alg_mod.f90. Done means global reduction builtins are available for fields and these existing min/max routines can be removed as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran, python
Domain
compilers, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.