PSyclone support for user-defined kernels that act on DoFs
@mo-alistairp is already working on this.
Since Mar 21, 2025.
- Dominant language
- Python
- Stars
- 3
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
In the past PSyclone didn't support user-defined kernerls that act on DoFs. As of PSyclone 3.0.0, this has been resolved (see PSyclone Issue #1351). Furthermore, as of PSyclone 3.1.0 user-defined DoF kernels should also work with field vectors (see PSyclone Issue #2892). This should allow the removal of
invoke_convert_cart2sphere_vectorinvoke_pointwise_convert_xyz2llr
found in components/science/source/psy/sci_psykal_builtin_light_mod in LFRic core. This is being addressed in the linked LFRic core #4535 and LFRic apps #575 tickets.
Currently, invoke_convert_cart2sphere_vector is being called in LFRic apps
applications/adjoint_tests/source/algorithm/adjt_convert_cart2sphere_vector_alg_mod.x90science/gungho/source/algorithm/diagnostics/diagnostic_alg_mod.x90science/gungho/source/algorithm/interpolation/interpolation_alg_mod.x90science/gungho/source/algorithm/physics/map_fd_to_prognostics_alg_mod.x90science/gungho/source/algorithm/physics/physics_mappings_alg_mod.x90
and invoke_pointwise_convert_xyz2llr is called in LFRic apps science/gungho/source/algorithm/diagnostics/diagnostic_alg_mod.x90 and LFRic core components/lfric-xios/source/lfric_xios_setup_mod.x90.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.